🤖 refactor: stack logo above version in title bar #1634
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ammar-agent
force-pushed
the
title-bar-logo-stacked
branch
2 times, most recently
from
ea75e5c to
6aec2df
Compare
When macOS traffic lights are present (leftInset > 0), stack the mux logo above the version string to fit in constrained space. Otherwise keep the original side-by-side layout. - Conditional flex-col vs items-center gap-2 based on leftInset - Smaller logo/badge/text sizes when stacked (h-3 vs h-4, text-[10px] vs text-xs) - Restore -translate-y-px adjustment for side-by-side layout - Add MacOSDesktop storybook story to capture the traffic light layout
ammar-agent
force-pushed
the
title-bar-logo-stacked
branch
from
6aec2df to
0a85396
Compare
ammar-agent
added a commit
that referenced
this pull request
Jan 15, 2026
PR #1634 changed the desktop titlebar height from h-8 (32px) to h-10 (40px), but the LeftSidebar's collapsed border pseudo-element still used top-8. This caused a 8px misalignment where the border would start above the titlebar's bottom edge. Update the pseudo-element offset from after:top-8 to after:top-10 to correctly align with the titlebar bottom edge in desktop mode.
ammar-agent
added a commit
that referenced
this pull request
Jan 15, 2026
PR #1634 changed the desktop titlebar height from h-8 (32px) to h-10 (40px), but the LeftSidebar's collapsed border pseudo-element still used top-8. This caused a 8px misalignment where the border would start above the titlebar's bottom edge. Update the pseudo-element offset from after:top-8 to after:top-10 to correctly align with the titlebar bottom edge in desktop mode.
ammar-agent
added a commit
that referenced
this pull request
Jan 15, 2026
PR #1634 changed the desktop titlebar height from h-8 (32px) to h-10 (40px), which caused horizontal misalignment with other title bar components. Setting to 35px provides better alignment. **Changes:** - Add DESKTOP_TITLEBAR_HEIGHT (35px) and DESKTOP_TITLEBAR_HEIGHT_CLASS constants to useDesktopTitlebar.ts - Update TitleBar, WorkspaceHeader, RightSidebarTabStrip, and LeftSidebar to use the shared constants instead of hardcoded values
ethanndickson
pushed a commit
that referenced
this pull request
Jan 15, 2026
When macOS traffic lights are present (leftInset > 0), stack the mux logo above the version string to fit in constrained space. Otherwise keep the original side-by-side layout. **Changes:** - Conditional `flex-col` vs `items-center gap-2` based on `leftInset` - Smaller logo/badge/text sizes when stacked (`h-3` vs `h-4`, `text-[10px]` vs `text-xs`) - Restore `-translate-y-px` adjustment for side-by-side layout --- _Generated with `mux` • Model: `anthropic:claude-opus-4-5` • Thinking: `high` • Cost: `$0.29`_
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When macOS traffic lights are present (leftInset > 0), stack the mux logo above the version string to fit in constrained space. Otherwise keep the original side-by-side layout.
Changes:
flex-colvsitems-center gap-2based onleftInseth-3vsh-4,text-[10px]vstext-xs)-translate-y-pxadjustment for side-by-side layoutGenerated with
mux• Model:anthropic:claude-opus-4-5• Thinking:high• Cost:$0.29